Skip to content

Conversation

Jack251970
Copy link
Member

Fix possible win32 exception for keyboard switch


Please open new issue in https://github.com/Flow-Launcher/Flow.Launcher/issues
1. Upload log file: C:\Users\11602\AppData\Roaming\FlowLauncher\Logs\1.19.5\2025-04-13.txt
2. Copy below exception message

Flow Launcher version: 1.19.5
OS Version: 26100.3775
IntPtr Length: 8
x64: True

Python Path: C:\Users\11602\AppData\Roaming\FlowLauncher\Environments\Python\PythonEmbeddable-v3.11.4\pythonw.exe
Node Path: C:\Program Files\nodejs\node.exe

Date: 04/13/2025 20:27:38
Exception:
System.ComponentModel.Win32Exception (0x80004005): The operation completed successfully.
   at Flow.Launcher.Infrastructure.Win32Helper.SwitchToEnglishKeyboardLayout(Boolean backupPrevious) in C:\projects\flow-launcher\Flow.Launcher.Infrastructure\Win32Helper.cs:line 379
   at Flow.Launcher.ViewModel.MainViewModel.Show() in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 1527
   at Flow.Launcher.ViewModel.MainViewModel.ToggleFlowLauncher() in C:\projects\flow-launcher\Flow.Launcher\ViewModel\MainViewModel.cs:line 1468
   at Flow.Launcher.Helper.HotKeyMapper.OnToggleHotkey(Object sender, HotkeyEventArgs args) in C:\projects\flow-launcher\Flow.Launcher\Helper\HotKeyMapper.cs:line 32
   at NHotkey.HotkeyManagerBase.HandleHotkeyMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled, Hotkey& hotkey)
   at NHotkey.Wpf.HotkeyManager.HandleMessage(IntPtr hwnd, Int32 msg, IntPtr wparam, IntPtr lparam, Boolean& handled)
   at System.Windows.Interop.HwndSource.PublicHooksFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Fix #3428.

@Jack251970 Jack251970 added the Dev branch only An issue or fix for the Dev branch build label Apr 13, 2025
@Jack251970 Jack251970 added this to the 1.20.0 milestone Apr 13, 2025
@Jack251970 Jack251970 self-assigned this Apr 13, 2025
@prlabeler prlabeler bot added the bug Something isn't working label Apr 13, 2025
Copy link

gitstream-cm bot commented Apr 13, 2025

🚨 Warning: Approaching Monthly Automation Limit

Monthly PRs automated: 238/250

Your organization has used over 90% of its monthly quota for gitStream automations. Once the quota is reached, new pull requests for this month will not trigger gitStream automations and will be marked as “Skipped”.

To avoid interruptions, consider optimizing your automation usage or upgrading your plan by contacting LinearB.

@Jack251970 Jack251970 requested a review from onesounds April 13, 2025 12:37
@Jack251970 Jack251970 enabled auto-merge April 13, 2025 12:37
@Jack251970
Copy link
Member Author

Small fix and it is good to me.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ forbidden-pattern 22
⚠️ non-alpha-in-dictionary 19

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Copy link

gitstream-cm bot commented Apr 13, 2025

🥷 Code experts: no user but you matched threshold 10

Jack251970 has most 👩‍💻 activity in the files.
Jack251970 has most 🧠 knowledge in the files.

See details

Flow.Launcher.Infrastructure/Win32Helper.cs

Activity based on git-commit:

Jack251970
APR 104 additions & 9 deletions
MAR 581 additions & 226 deletions
FEB 13 additions & 16 deletions
JAN 0 additions & 138 deletions
DEC 243 additions & 4 deletions
NOV

Knowledge based on git-blame:
Jack251970: 93%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Apr 13, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

Copy link
Contributor

coderabbitai bot commented Apr 13, 2025

📝 Walkthrough

Walkthrough

This change modifies the error handling within the SwitchToEnglishKeyboardLayout method in the Win32Helper class. Instead of throwing a Win32Exception when the foreground window change fails, the method now assigns the current foreground window handle and proceeds. No public API changes were made.

Changes

File Path Change Summary
Flow.Launcher.Infrastructure/Win32Helper.cs Updated error handling in the SwitchToEnglishKeyboardLayout method to bypass throwing a Win32Exception on failure and assign the current window handle instead.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Win32Helper
    participant OS

    Caller->>Win32Helper: Call SwitchToEnglishKeyboardLayout()
    Win32Helper->>OS: Invoke SetForegroundWindow()
    alt Success
        OS-->>Win32Helper: Success
        Win32Helper->>Caller: Proceed with new foreground window
    else Failure
        OS-->>Win32Helper: Failure
        Win32Helper->>Win32Helper: Assign current foreground window handle
        Win32Helper->>Caller: Proceed with current window handle
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Handle foreground window setting failure without crashing ([#3428])

Poem

I’m a rabbit hopping through the code,
Skipping bugs off a bumpy road.
No more crashes when windows shift,
Error handling gives a graceful lift.
With a twitching nose and joyful cheer,
I celebrate fixes far and near!
🐇✨ Happy hops in every byte!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9dd5f06 and eec6145.

📒 Files selected for processing (1)
  • Flow.Launcher.Infrastructure/Win32Helper.cs (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
Flow.Launcher.Infrastructure/Win32Helper.cs (1)
Flow.Launcher.Infrastructure/PInvokeExtensions.cs (1)
  • PInvoke (8-25)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: gitStream workflow automation
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
🔇 Additional comments (1)
Flow.Launcher.Infrastructure/Win32Helper.cs (1)

378-381: Good error handling improvement.

The change correctly addresses a potential Win32 exception by gracefully continuing execution when SetForegroundWindow fails, rather than throwing an exception. This allows the keyboard layout switching to proceed with the current foreground window instead of failing completely.

This change aligns with the PR objective to fix the Win32 exception when switching to the English keyboard layout.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jack251970 Jack251970 disabled auto-merge April 13, 2025 13:03
@Jack251970 Jack251970 requested review from onesounds and removed request for onesounds April 13, 2025 13:03
@Jack251970 Jack251970 enabled auto-merge April 13, 2025 13:06
@Jack251970 Jack251970 merged commit 62935db into dev Apr 13, 2025
13 checks passed
@Jack251970 Jack251970 deleted the keyboard_win32_exception branch April 13, 2025 17:00
@jjw24 jjw24 removed the bug Something isn't working label May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dev branch only An issue or fix for the Dev branch build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: I did full clean install of flow launcher, but found this error, and cant fix it,

3 participants